scripts: check binary exit code in gen-manpages.py

Now that bitcoin-wallet no-longer returns a non-zero exit code when it
shouldn't do, we can add check=True to our subprocess call.

Follows up to the comments in
bitcoin#24263 (comment).

Author: fanquake

contrib/devtools/gen-manpages.py

@@ -36,7 +36,7 @@
 for relpath in BINARIES:
     abspath = os.path.join(builddir, relpath)
     try:
-        r = subprocess.run([abspath, '--version'], stdout=subprocess.PIPE, universal_newlines=True)
+        r = subprocess.run([abspath, '--version'], stdout=subprocess.PIPE, check=True, universal_newlines=True)
     except IOError:
         print(f'{abspath} not found or not an executable', file=sys.stderr)
         sys.exit(1)