Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Mismatch constructor parameters in script and contract #415

Open
Skyge opened this issue May 16, 2024 · 0 comments
Open

bug: Mismatch constructor parameters in script and contract #415

Skyge opened this issue May 16, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Skyge
Copy link

Skyge commented May 16, 2024

When I try to use script/DeployL2.s.sol to deploy contracts, I find something weird, in this script, the code to deploy contract KeyGateway is:

addrs.keyGateway = register(
            "KeyGateway",
            params.salts.keyGateway,
            type(KeyGateway).creationCode,
            abi.encode(addrs.keyRegistry, addrs.storageRegistry, params.initialKeyRegistryOwner)
        );

And I find in the contract src/KeyGateway.sol, it only needs two constructor parameters like this:

constructor(
        address _keyRegistry,
        address _initialOwner
    ) Guardians(_initialOwner) EIP712("Farcaster KeyGateway", "1") {
        keyRegistry = IKeyRegistry(_keyRegistry);
    }
@Skyge Skyge added the bug Something isn't working label May 16, 2024
@Skyge Skyge changed the title bug: Mismatch constructor parameters bug: Mismatch constructor parameters in script and contract May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants