Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Subscription support #69

Open
tqma113 opened this issue Apr 29, 2021 · 7 comments
Open

Feature Request: Subscription support #69

tqma113 opened this issue Apr 29, 2021 · 7 comments
Labels
enhancement New feature or request

Comments

@tqma113
Copy link
Collaborator

tqma113 commented Apr 29, 2021

Like Subscription of GraphQL, maybe by WebSocket?

@Lucifier129
Copy link
Collaborator

It seems easy to implement something like subscription via WebSocket or Polling in user-land.

For now, I don't know much about what we need to support internally.

If you already have some idea, please explain what you want to do here.

@tqma113
Copy link
Collaborator Author

tqma113 commented Apr 29, 2021

I know how to implement Subscription by Polling in user-land. And I think it needs support internally if implement it by WebSocket. And the Polling way will take more overload network resource than WebSocket way. If are there another way I do not know?

@Lucifier129
Copy link
Collaborator

Yeah, I got it.

If we want to use farrow-api via WebSocket, we need to add the codegen support in farrow-api. It may cause some degree of refactoring. It's not easy work to do.

I prefer to delay this feature until wide users of Farrow strongly request it, or we finally find out an easy way to implement it.

@Lucifier129 Lucifier129 added the enhancement New feature or request label Apr 29, 2021
@tqma113
Copy link
Collaborator Author

tqma113 commented Apr 29, 2021

Can there be a Subprogramme first? Such as a new package like farrow-subscription

@sinoon
Copy link
Contributor

sinoon commented Apr 29, 2021

Does farrow support websocket now?

@Lucifier129
Copy link
Collaborator

Can there be a Subprogramme first? Such as a new package like farrow-subscription

It's good, for the experiment.

@Lucifier129
Copy link
Collaborator

Does farrow support websocket now?

Not yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants