Skip to content
This repository was archived by the owner on Aug 15, 2021. It is now read-only.

Commit 37a07d3

Browse files
committed
2019-12-26 Version 2.1.1: Refactored project structure and implemented Dagger 2
1 parent b269839 commit 37a07d3

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

48 files changed

+532
-602
lines changed

.travis.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ android:
88
- platform-tools
99
- build-tools-29.0.2
1010
- android-29
11-
- android-22
1211
- extra-android-m2repository
1312
- extra-android-support
1413
- extra-google-m2repository

app/build.gradle

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ apply plugin: 'com.android.application'
22
apply plugin: 'kotlin-android'
33
apply plugin: 'kotlin-android-extensions'
44
apply plugin: 'io.gitlab.arturbosch.detekt'
5+
apply plugin: 'kotlin-kapt'
56

67
android {
78
compileSdkVersion 29
@@ -11,7 +12,7 @@ android {
1112
minSdkVersion 21
1213
targetSdkVersion 29
1314
versionCode 1
14-
versionName "2.1.0"
15+
versionName "2.1.1"
1516

1617
testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
1718
}
@@ -50,6 +51,10 @@ dependencies {
5051
// FAB menu
5152
implementation 'me.jahirfiquitiva:FABsMenu:1.1.4'
5253

54+
// Dagger 2
55+
implementation 'com.google.dagger:dagger:2.24'
56+
kapt 'com.google.dagger:dagger-compiler:2.24'
57+
5358
// Unit tests
5459
testImplementation 'junit:junit:4.12'
5560

app/src/androidTest/java/com/smlnskgmail/jaman/randomnotes/AndroidTestSuite.kt

Lines changed: 0 additions & 13 deletions
This file was deleted.

app/src/androidTest/java/com/smlnskgmail/jaman/randomnotes/db/NoteDBTest.kt

Lines changed: 0 additions & 24 deletions
This file was deleted.

app/src/androidTest/java/com/smlnskgmail/jaman/randomnotes/ui/note/BaseNoteTest.kt

Lines changed: 0 additions & 28 deletions
This file was deleted.

app/src/androidTest/java/com/smlnskgmail/jaman/randomnotes/ui/note/NoteCreationTest.kt

Lines changed: 0 additions & 61 deletions
This file was deleted.

app/src/androidTest/java/com/smlnskgmail/jaman/randomnotes/ui/utils/ChildClick.kt

Lines changed: 0 additions & 26 deletions
This file was deleted.

app/src/main/java/com/smlnskgmail/jaman/randomnotes/Application.kt

Lines changed: 33 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,48 @@
11
package com.smlnskgmail.jaman.randomnotes
22

33
import android.app.Application
4-
import com.smlnskgmail.jaman.randomnotes.logic.sources.ormlite.OrmLiteDataSource
5-
import com.smlnskgmail.jaman.randomnotes.logic.sources.parse.ParseDataSource
6-
import com.smlnskgmail.jaman.randomnotes.repository.DataRepositoryAccessor
4+
import com.smlnskgmail.jaman.randomnotes.di.ApplicationComponent
5+
import com.smlnskgmail.jaman.randomnotes.di.CloudAuthModule
6+
import com.smlnskgmail.jaman.randomnotes.di.DaggerApplicationComponent
7+
import com.smlnskgmail.jaman.randomnotes.di.DataRepositoryModule
8+
import com.smlnskgmail.jaman.randomnotes.logic.repository.DataRepository
9+
import com.smlnskgmail.jaman.randomnotes.logic.repository.sources.ormlite.OrmLiteDataSource
10+
import com.smlnskgmail.jaman.randomnotes.logic.repository.sources.parse.ParseAuth
11+
import com.smlnskgmail.jaman.randomnotes.logic.repository.sources.parse.ParseDataSource
12+
import javax.inject.Inject
713

814
@Suppress("unused")
915
class Application : Application() {
1016

17+
companion object {
18+
19+
lateinit var applicationComponent: ApplicationComponent
20+
21+
}
22+
23+
@Inject
24+
lateinit var dataRepository: DataRepository
25+
1126
override fun onCreate() {
1227
super.onCreate()
13-
DataRepositoryAccessor.initWith(
14-
OrmLiteDataSource(this),
15-
ParseDataSource(this)
16-
)
28+
applicationComponent = DaggerApplicationComponent.builder()
29+
.withDataRepository(
30+
DataRepositoryModule(
31+
OrmLiteDataSource(this),
32+
ParseDataSource(this)
33+
)
34+
)
35+
.withCloudAuth(
36+
CloudAuthModule(
37+
ParseAuth()
38+
)
39+
)
40+
.build()
41+
applicationComponent.inject(this)
1742
}
1843

1944
override fun onTerminate() {
20-
DataRepositoryAccessor.free()
45+
dataRepository.destroy()
2146
super.onTerminate()
2247
}
2348

app/src/main/java/com/smlnskgmail/jaman/randomnotes/MainActivity.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@ import android.os.Bundle
44
import androidx.appcompat.app.AppCompatActivity
55
import androidx.fragment.app.Fragment
66
import androidx.fragment.app.FragmentManager
7-
import com.smlnskgmail.jaman.randomnotes.components.BaseFragment
8-
import com.smlnskgmail.jaman.randomnotes.components.FragmentResume
7+
import com.smlnskgmail.jaman.randomnotes.components.fragments.BaseFragment
8+
import com.smlnskgmail.jaman.randomnotes.components.fragments.lifecycle.FragmentResume
99
import com.smlnskgmail.jaman.randomnotes.logic.login.LoginFragment
1010
import com.smlnskgmail.jaman.randomnotes.logic.main.MainFragment
1111

app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/BaseBottomSheet.kt renamed to app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/bottomsheets/BaseBottomSheet.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.smlnskgmail.jaman.randomnotes.components
1+
package com.smlnskgmail.jaman.randomnotes.components.bottomsheets
22

33
import android.os.Bundle
44
import android.view.LayoutInflater
@@ -8,12 +8,6 @@ import com.google.android.material.bottomsheet.BottomSheetDialogFragment
88

99
abstract class BaseBottomSheet : BottomSheetDialogFragment() {
1010

11-
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
12-
initialize()
13-
}
14-
15-
abstract fun initialize()
16-
1711
override fun onCreateView(
1812
inflater: LayoutInflater,
1913
container: ViewGroup?, savedInstanceState: Bundle?

app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/views/AdaptiveRecyclerView.java renamed to app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/containers/AdaptiveRecyclerView.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.smlnskgmail.jaman.randomnotes.components.views;
1+
package com.smlnskgmail.jaman.randomnotes.components.containers;
22

33
import android.content.Context;
44
import android.util.AttributeSet;
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.smlnskgmail.jaman.randomnotes.components
1+
package com.smlnskgmail.jaman.randomnotes.components.dialogs
22

33
import android.app.Dialog
44
import android.content.Context
@@ -10,15 +10,12 @@ abstract class BaseDialog(context: Context) : Dialog(context) {
1010
override fun onCreate(savedInstanceState: Bundle?) {
1111
super.onCreate(savedInstanceState)
1212
setContentView(getLayoutResId())
13-
initializeDialog()
1413
window!!.setLayout(
1514
ViewGroup.LayoutParams.MATCH_PARENT,
1615
ViewGroup.LayoutParams.WRAP_CONTENT
1716
)
1817
}
1918

20-
abstract fun initializeDialog()
21-
2219
abstract fun getLayoutResId(): Int
2320

2421
}

app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/BaseFragment.kt renamed to app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/fragments/BaseFragment.kt

Lines changed: 4 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,23 @@
1-
package com.smlnskgmail.jaman.randomnotes.components
1+
package com.smlnskgmail.jaman.randomnotes.components.fragments
22

33
import android.os.Bundle
44
import android.view.*
55
import androidx.fragment.app.Fragment
6+
import com.smlnskgmail.jaman.randomnotes.components.fragments.lifecycle.FragmentResume
67

78
abstract class BaseFragment : Fragment(), FragmentResume {
89

910
private lateinit var menu: Menu
1011

1112
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
12-
onViewCreated()
13+
setHasOptionsMenu(true)
14+
setTitle()
1315
}
1416

1517
private fun setTitle() {
1618
activity!!.setTitle(getTitleResId())
1719
}
1820

19-
open fun onViewCreated() {
20-
setHasOptionsMenu(true)
21-
setTitle()
22-
}
23-
2421
override fun onFragmentResume() {
2522
setTitle()
2623
}
@@ -65,9 +62,3 @@ abstract class BaseFragment : Fragment(), FragmentResume {
6562
}
6663

6764
}
68-
69-
interface FragmentResume {
70-
71-
fun onFragmentResume()
72-
73-
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
package com.smlnskgmail.jaman.randomnotes.components.fragments.lifecycle
2+
3+
interface FragmentResume {
4+
5+
fun onFragmentResume()
6+
7+
}

app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/LongToast.kt renamed to app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/views/LongToast.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package com.smlnskgmail.jaman.randomnotes.components
1+
package com.smlnskgmail.jaman.randomnotes.components.views
22

33
import android.content.Context
44
import android.widget.Toast

app/src/main/java/com/smlnskgmail/jaman/randomnotes/components/views/VectorDrawableButton.java

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,8 +75,13 @@ private void initSupportVectorDrawablesAttrs(AttributeSet attrs) {
7575
}
7676
}
7777

78-
TextViewCompat.setCompoundDrawablesRelativeWithIntrinsicBounds(this,
79-
drawableStart, drawableTop, drawableEnd, drawableBottom);
78+
TextViewCompat.setCompoundDrawablesRelativeWithIntrinsicBounds(
79+
this,
80+
drawableStart,
81+
drawableTop,
82+
drawableEnd,
83+
drawableBottom
84+
);
8085

8186
attributeArray.recycle();
8287
}

0 commit comments

Comments
 (0)