Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More memory aware #19

Closed
farzadghanei opened this issue Sep 25, 2020 · 1 comment
Closed

More memory aware #19

farzadghanei opened this issue Sep 25, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@farzadghanei
Copy link
Owner

If the system is running out of memory, mute crashes and Go runtime dumps a stack trace. Would be nice to be able to improve on this. A couple of ideas:

  • help to reduce memory usage (maybe guide Go runtime GC)
  • Watch for low memory when accumulating the output, and dump whatever caught before the process crashes
@farzadghanei farzadghanei added the enhancement New feature or request label Sep 25, 2020
@farzadghanei
Copy link
Owner Author

#20 restructured mute.Exec into 2 separate functions, which could help with GC being able to claim/reuse memory more efficiently, as some portion of memory would be out of scope sooner, before continuing with matching output against configured criteria.

As for watching for low memory, finding a platform solution would bring complications, and support from Go runtime to be notified of memory pressure is not as available. So let's wait to see what the runtime would provide in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant