Move the style overrides to a separate HTML widget #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the styles every time we update the widget causes Safari to recalculate the styles and the layout for the whole notebook which completely ruins performance (100ms layouts on each update on an Apple M1). If we output the styles as a separate widget the browser only inteprets them once and layout times on updates stay < 10ms.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
I just verified that this patch indeed fixes perf issues with progress bar in Safari. Specifically, I manually patched my local fastprogress package install and see CPU usage dropping from 100% to <2% while progress bar is updating in Safari. @sgugger it would be great to get this patch in! |
|
Looks good to me! Thanks for fixing! |
|
Hi, thanks for merging my change. Could we release a new minor version of the package? Installing from the repo is currently the only way to make fastai usable in Safari. |
|
Many apologies for the extremely slow release of this @jpc -- done now. (And thanks for the reminder) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the styles every time we update the widget causes Safari to recalculate the styles and the layout for the whole notebook which completely ruins performance (100ms layouts on each update on an Apple M1). If we output the styles as a separate widget the browser only interprets them once and layout times on updates stay < 10ms.