Fix: correct notebook2html path operation for Windows. #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the default project structure, the glob() in notebook2html() can easilly find a copy of a .ipynb file in .ipynb_checkpoints. In this case, running nbdev_build_docs will fail, assuming the .ipynb imports the project (the relative path is not correct from this dir.) The current code to skip hidden path components searches for '/.', whereas str(f) will return the Windows backslash path, so the search will fail. f.as_posix() returns a '/' delimited path on all platforms. I verified failure of nbdev_build_docs before the fix, and success after installing the fix.
|
Check out this pull request on Review Jupyter notebook visual diffs & provide feedback on notebooks. Powered by ReviewNB |
|
Many thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the default project structure, the glob() in notebook2html() can easilly find a copy of a .ipynb file in .ipynb_checkpoints. In this case, running nbdev_build_docs will fail, assuming the .ipynb imports the project (the relative path is not correct from this dir.) The current code to skip hidden path components searches for '/.', whereas str(f) will return the Windows backslash path, so the search will fail. f.as_posix() returns a '/' delimited path on all platforms.
I verified failure of nbdev_build_docs before the fix, and success after installing the fix.