-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support windows #392
support windows #392
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for the PR! Just one suggestion to try out please.
`parallel` uses fastai's ProcessPoolExecutor, not the stdlib one, which behaves differently with n_workers=0. Try it :)
|
@jph00 <https://github.com/jph00> , Thank your reply. it was stuck when if n_workers=0.
I find it's caused by https://github.com/fastai/fastcore/blob/8ddf4dde118dea53daf849d7a5f2dc425ca49390/fastcore/parallel.py#L84-L85.
The Manager().Lock() spawns a new process.
Could we don't set self.lock = Manager().Lock() <https://www.fastmail.com/mail/url?u=35e541ae> when it is not_parallel?
Ah great find - yes feel free to submit a PR to add a condition there. (And please at-mention me on any PRs you do)
|
git diff throws exception without https://github.com/mszhanyi/nbdev/blob/93ceef10b29e2d897f2e14d8ed1c81fbcab0bc53/nbdev/clean.py#L85 |
Super - thank you :) |
fix #393
2.1 Unix path is not applicable on Windows
2.2 Notebook could not use parallel on Windows