[Bug]: Explorer page, binary tab, fails to show images.

[madhacker3kxl]

Contact Details

No response

What happened?

When viewing the explorer page and in binary tab, click on an image/jpeg shows an error.

Flavor

Docker

Version

main#e4a73ff

Relevant log output

level=error msg="An error occurred while retrieving resource no resource found with source id 6dccfd76-53a1-4ca3-b130-b387f954011e and source resource id aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc" type=web

[AnalogJ]

figured out the issue. We arn't url-encoding the source-resource-id, which is base64 encoded in some cases

aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc=

should be:

aHR0cHM6Ly93d3cubWVyY3kubmV0L3NpdGVzL2RlZmF1bHQvZmlsZXMvZG9jdG9yX2ltYWdlcy9kZXNrdG9wLzE2NTk4ODYwNTktbS5qcGc%3D

the = is a reserved character in URLs.

[madhacker3kxl]

Nice catch! Noticed that the log I attached above does not have the "="

[AnalogJ]

yep, I'll work on getting that fixed. There's about a dozen different places where we do that, so it might take a bit :(