Skip to content

Commit bd4439f

Browse files
committed
Auto merge of rust-lang#12829 - fasterthanlime:in-rust-tree-feature, r=Veykril
Remove `check_merge_commits` test Due to the way "git subtree" works, the `check_merge_commits` test _will_ find merge commits and fail, so we simply skip it. This changed is tracked in: * rust-lang/rust-analyzer#12818 Maintainer impact: none
2 parents 100ea1d + 244f29b commit bd4439f

File tree

1 file changed

+0
-50
lines changed
  • crates/rust-analyzer/tests/slow-tests

1 file changed

+0
-50
lines changed

crates/rust-analyzer/tests/slow-tests/tidy.rs

-50
Original file line numberDiff line numberDiff line change
@@ -142,56 +142,6 @@ fn check_cargo_toml(path: &Path, text: String) {
142142
}
143143
}
144144

145-
#[test]
146-
fn check_merge_commits() {
147-
let sh = &Shell::new().unwrap();
148-
149-
let bors = cmd!(sh, "git rev-list --merges --author 'bors' HEAD~19..").read().unwrap();
150-
let all = cmd!(sh, "git rev-list --merges HEAD~19..").read().unwrap();
151-
if bors != all {
152-
panic!(
153-
"
154-
Merge commits are not allowed in the history.
155-
156-
When updating a pull-request, please rebase your feature branch
157-
on top of master by running `git rebase master`. If rebase fails,
158-
you can re-apply your changes like this:
159-
160-
# Just look around to see the current state.
161-
$ git status
162-
$ git log
163-
164-
# Abort in-progress rebase and merges, if any.
165-
$ git rebase --abort
166-
$ git merge --abort
167-
168-
# Make the branch point to the latest commit from master,
169-
# while maintaining your local changes uncommited.
170-
$ git reset --soft origin/master
171-
172-
# Commit all changes in a single batch.
173-
$ git commit -am'My changes'
174-
175-
# Verify that everything looks alright.
176-
$ git status
177-
$ git log
178-
179-
# Push the changes. We did a rebase, so we need `--force` option.
180-
# `--force-with-lease` is a more safe (Rusty) version of `--force`.
181-
$ git push --force-with-lease
182-
183-
# Verify that both local and remote branch point to the same commit.
184-
$ git log
185-
186-
And don't fear to mess something up during a rebase -- you can
187-
always restore the previous state using `git ref-log`:
188-
189-
https://github.blog/2015-06-08-how-to-undo-almost-anything-with-git/#redo-after-undo-local
190-
"
191-
);
192-
}
193-
}
194-
195145
fn deny_clippy(path: &Path, text: &str) {
196146
let ignore = &[
197147
// The documentation in string literals may contain anything for its own purposes

0 commit comments

Comments
 (0)