Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove panic #31

Closed
kiwec opened this issue Nov 23, 2020 · 1 comment
Closed

Remove panic #31

kiwec opened this issue Nov 23, 2020 · 1 comment

Comments

@kiwec
Copy link

kiwec commented Nov 23, 2020

Panic at https://github.com/fasthttp/session/blob/master/internal/sql/provider.go#L150 should be removed to avoid crashing production services, when the error can just be ignored silently.

@savsgio
Copy link
Member

savsgio commented Dec 13, 2020

Hi @kiwec,

Sorry for delayed answer.

I fixed to return and log the error, instead of panic!

I'll release a new version soon.

Thanks! 😉

@savsgio savsgio closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants