-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Need to get full header #127
Comments
Your opinions? Afaik you wanted to replace busboy in undici with this version. Do you see any drawbacks? |
fyi, related to: nodejs/undici#2283 |
Can you please take over this issue? I am currently bound by refactoring probot as at work upgrading our github bots is stalled. So I am kind of mentally blocked to handle more than two super complex packages. I see following tasks:
|
undici is probably not going to expose full headers from any field, it's just for mine and other sake of being able to know what all the headers on a given field are... some custom libraries batch multiple request into one single multipart/form-data So knowing all headers could be useful for others who are interested in this busboy. (like a custom express middleware) |
2D array is important b/c a header could be added twice. |
Should be doable, I'll try to take a look at this |
@jimmywarting |
I would expect the header parsing to allow semicolons. |
Undici is going to need it to get access to the raw header in order to get the full / as is undici is just not going to expose the raw headers to the client using fetch. |
Prerequisites
🚀 Feature Proposal
I need to get the full raw headers from each field, as is, without any modification.
Motivation
You do strip out quite a bit, and leave many things behind.
headers that are not known to you gets discarded, headers meta
;key=value
pair gets discarded too.And some things even get modified as you apply to lowercase here and there.
I need to parse the headers on my own, so it would be good if you could send the headers as a 2D iterable array
(as one header could appair twice)
Example
the arguments length is getting out of control cuz they are so many now. and i don't need all of them... An object would be better...
so that i could do:
The text was updated successfully, but these errors were encountered: