-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bring back the support for Node.js v16 #94
Comments
@gurgunday @jsumners wdyt? |
We already test for node 16? Did you mean node 14? fast-uri/.github/workflows/ci.yml Line 23 in 986abce
|
Do we want a custom workflow to test it in the browser? I don’t understand why tape is needed |
latest tap does not support node v16 and v18. |
I think tape is acceptable in this case, because we could then also implement #21 easily, as it would be a copy paste solution from readable-stream repo. |
Won't AJV need to drop Node 16 in a few short (😭) months anyway? |
I just released AJV 8.17.1 with fast-uri. I hadn't seen this, but you're right, we'd be looking at dropping it soon. Hopefully this doesn't cause too many problems. I mean, 16 is about 6 months over the maintenance window. Also it must work because our test suite runs 16 with fast-uri. |
We now use For browser support, it should be working already, and the custom CI to run automated browser tests can be tracked at #21 |
Given our goal for fast-uri to be the default of ajv, I think we should bring back support for Node.js v16. This would mean:
The text was updated successfully, but these errors were encountered: