Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back the support for Node.js v16 #94

Closed
2 tasks done
mcollina opened this issue Jun 27, 2024 · 8 comments
Closed
2 tasks done

bring back the support for Node.js v16 #94

mcollina opened this issue Jun 27, 2024 · 8 comments

Comments

@mcollina
Copy link
Member

mcollina commented Jun 27, 2024

Given our goal for fast-uri to be the default of ajv, I think we should bring back support for Node.js v16. This would mean:

  • switch to use tape instead of tap
  • use a custom action
@mcollina
Copy link
Member Author

@gurgunday @jsumners wdyt?

@gurgunday
Copy link
Member

We already test for node 16? Did you mean node 14?

node-versions: '["16", "18", "20"]'

@gurgunday
Copy link
Member

Do we want a custom workflow to test it in the browser? I don’t understand why tape is needed

@mcollina
Copy link
Member Author

latest tap does not support node v16 and v18.

@Uzlopak
Copy link
Contributor

Uzlopak commented Jun 27, 2024

I think tape is acceptable in this case, because we could then also implement #21 easily, as it would be a copy paste solution from readable-stream repo.

@jsumners
Copy link
Member

Won't AJV need to drop Node 16 in a few short (😭) months anyway?

@jasoniangreen
Copy link

jasoniangreen commented Jul 12, 2024

I just released AJV 8.17.1 with fast-uri. I hadn't seen this, but you're right, we'd be looking at dropping it soon. Hopefully this doesn't cause too many problems. I mean, 16 is about 6 months over the maintenance window.

Also it must work because our test suite runs 16 with fast-uri.

@gurgunday
Copy link
Member

We now use tape and the CI successfully tests fast-uri on node 16

For browser support, it should be working already, and the custom CI to run automated browser tests can be tracked at #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants