Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #384 : underscore in parameters name #385

Merged
merged 1 commit into from
Mar 16, 2021
Merged

fix #384 : underscore in parameters name #385

merged 1 commit into from
Mar 16, 2021

Conversation

briceruzand
Copy link
Contributor

fix #384

@coveralls
Copy link

coveralls commented Mar 15, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 654449746

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 653760674: 0.0%
Covered Lines: 460
Relevant Lines: 460
💛 - Coveralls

mcollina
mcollina approved these changes Mar 15, 2021
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina requested a review from climba03003 March 15, 2021 14:29
climba03003
climba03003 approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@climba03003 climba03003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@climba03003 climba03003 merged commit bc09536 into fastify:master Mar 16, 2021
This was referenced Mar 16, 2021
Closed
Closed
Closed
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@Eomm Eomm Eomm approved these changes

@climba03003 climba03003 climba03003 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Since #372 underscore char in param is buggy
5 participants
@briceruzand @coveralls @mcollina @Eomm @climba03003