Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .clinic to .gitignore? #43

Closed
2 tasks done
Uzlopak opened this issue Sep 7, 2022 · 3 comments
Closed
2 tasks done

Add .clinic to .gitignore? #43

Uzlopak opened this issue Sep 7, 2022 · 3 comments
Labels
good first issue Good for newcomers

Comments

@Uzlopak
Copy link
Contributor

Uzlopak commented Sep 7, 2022

Prerequisites

  • I have written a descriptive issue title
  • I have searched existing issues to ensure the issue has not already been raised

Issue

@Fdawgs
I run node clinic and I the clinic artifacts in .clinic were not ignored. Maybe we should add them?

@Fdawgs Fdawgs self-assigned this Sep 7, 2022
@Fdawgs
Copy link
Member

Fdawgs commented Sep 7, 2022

Got an example of where you'd use this @Uzlopak? I use clinic but primarily for apps/APIs, is it also useful for testing modules/plugins in isolation?

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Sep 7, 2022

I investigate currently in fastify-session if there is any performance optimization possible. So what I do is to use the examples/memory.js and spin it up with node clinic and then autocannon it.

And in a perfect world, all plugins and modules should have examples :D

@Eomm
Copy link
Member

Eomm commented Sep 9, 2022

I run node clinic and I the clinic artifacts in .clinic were not ignored. Maybe we should add them?

I agree.

Adding stuff to a personal top level .gitignore does not stop npm from including it into the release

@Eomm Eomm added the good first issue Good for newcomers label Sep 9, 2022
@Fdawgs Fdawgs removed their assignment Sep 22, 2022
@Uzlopak Uzlopak closed this as completed Nov 5, 2022
This was referenced Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants