Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code snippets with links are incorrectly rendered #619

Closed
revolter opened this issue Jun 7, 2018 · 3 comments · Fixed by #1108
Closed

Code snippets with links are incorrectly rendered #619

revolter opened this issue Jun 7, 2018 · 3 comments · Fixed by #1108

Comments

@revolter
Copy link
Collaborator

revolter commented Jun 7, 2018

In this case:


screen shot 2018-06-07 at 15 07 39


Fastfiles, lanes and lane are not links, while cocoapods and carthage are links, but they look the same.

@janpio
Copy link
Member

janpio commented Aug 1, 2018

@janpio
Copy link
Member

janpio commented Aug 1, 2018

Code is:

<a href="https://docs.fastlane.tools/actions/cocoapods/"><code>cocoapods</code></a>

Font color of a code is defined as blue:

.rst-content a code {
    color: #2980B9;
}

but overwritten via !important for code:

code {
    font-family: Consolas, "Liberation Mono", Menlo, Courier, monospace !important;
    border-bottom-left-radius: 3px;
    border-bottom-right-radius: 3px;
    border-top-left-radius: 3px;
    border-top-right-radius: 3px;
    background-color: #f7f7f7 !important;
    color: #333 !important;
    font-size: 14px !important;
    border: none !important;
    padding: 5px !important;
}

in fastlane.css.

Without !important the color is as expected and the link is recognizable as such:

image

What could be the side effects?
Should we change it?

@revolter
Copy link
Collaborator Author

I will try to do this in #696.

@revolter revolter changed the title Code snippets with link are incorrectly rendered Code snippets with links are incorrectly rendered Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants