-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Requesting new iPhone 14 series skins #29
Comments
Looks like we are waiting on facebook to update their frames as that is what frameit uses: https://design.facebook.com/toolsandresources/devices/ |
Hi @bikee1235 please have a look at my PR here: |
Is there someone to merge the #31 PR? |
Please add the iPhone 14 series. Facebook has them already. I really need them. |
I set up a workaround and now have the latest frames including iPhone 14 and Samsung Galaxy S21+ lineup:
The repo contains the latest frames as of October 4th 2023. Including Samsung Galaxy S21+ and the iPhone 14 lineup. Edit 2: It is more complex than initially expected. Not only did some of the naming change as mentioned below, but also the images for iPhone 14 lineup are not pixel accurate size leading to broken framing. If you don't want to use my repo, you can also set this up with your own repo:
Edit: # Facebook's device naming is inconsistent. This method fixes the file names.
def sanitize_filename(filename)
perform_ipad_renaming(filename
.gsub('Grey', 'Gray') # some Apple devices have "Grey" instead of "Gray" color -> unify
.gsub(' - Portrait', '') # iPads Pro include Portrait and Landscape - we just need Portrait; Landscape filtered via DEVICES_TO_SKIP
.gsub(' - ', ' ') # Google Pixel device names are separated from their colors by a dash -> remove
.gsub(' — ', ' ') # Some Apple devices have a long dash -> replace
.gsub(' – ', ' ') # Some Apple devices have a special dash -> replace)
.gsub('Note10', 'Note 10') # Samsung Galaxy Note 10 is missing a space in "Note10"
.gsub('Mi Mix Alpha Front', 'Mi Mix Alpha')) # Xiaomi Mi Mix Alpha contains the words "Front", "Back" and "Side" => back and side are filtered via DEVICES_TO_SKIP, "Front" removed from the name here
end You also need to resize the images for the iPhone 14 lineup because they are not pixel accurate leading to images not being framed correctly. To do so I used the screen pixel width in the below code (e.g. 1170 for iPhone 14) to calculate how I need to resize the images. Make sure the screen size in the image is equal to this number. Do not confuse them width the image width because that is larger as it includes the phone frame as well. To actually make frameit be able to add the correct frames for the iPhone 14 lineup, I also needed to add the following lines to the file IPHONE_14 ||= Frameit::Device.new('iphone-14', 'iPhone 14', 14, [[2532, 1170], [1170, 2532]], 460, Color::MIDNIGHT, Platform::IOS)
IPHONE_14_PLUS ||= Frameit::Device.new('iphone-14-plus', 'iPhone 14 Plus', 14, [[2778, 1284], [1284, 2778]], 458, Color::MIDNIGHT, Platform::IOS)
IPHONE_14_PRO ||= Frameit::Device.new('iphone-14-pro', 'iPhone 14 Pro', 14, [[2556, 1179], [1179, 2556]], 460, Color::MIDNIGHT, Platform::IOS)
IPHONE_14_PRO_MAX ||= Frameit::Device.new('iphone-14-pro-max', 'iPhone 14 Pro Max', 14, [[2796, 1290], [1290, 2796]], 460, Color::MIDNIGHT, Platform::IOS) |
more than a year without answers, is fastlane dead? @joshdholtz |
Hi, there are now iPhone 15 and 16 lineup, can we have them too in some way? :( |
Hi
Can you please update latest iPhone skins
The text was updated successfully, but these errors were encountered: