New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expecting 404 on images that do no exist, but getting placeholder image instead #591

Closed

kavingas opened this issue Nov 29, 2022 · 1 comment

kavingas commented Nov 29, 2022 •

edited

Loading

Prerequisites:

Adobe Commerce 2.4-develop with Fastly least

Steps to reproduce:

Enable Fastly deep image optimization.
Access a random URL under the media directory.
E.g
/media/test.jpeg
Observe the 404 response code
Wait for 1 hour
Make the same request again
Observe 200 response code

(on) Screen recording https://shared-assets.adobe.com/link/0b4964de-3838-4e40-5428-fe8eb1433d2d

(x) Actual result:

After 1 hour from the initial request, all the requests made to the media directory return the 200 status code with a placeholder image.

(/) Expected result:

None existing images should respond with the 404 status code.

(i) extra details

The default Adobe Commerce execution process gets interrupted when the deep image optimization is enabled.
https://github.com/fastly/fastly-magento2/blob/master/Plugin/MediaStorage/App/AroundMedia.php#L67

bbutkovic mentioned this issue

add option to serve 404s on nonexistent images #597

Merged

Contributor

vvuksan commented Jan 10, 2023

Fixed in 1.2.194.

vvuksan closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment