Skip to content

c-branch-2#1894

Merged
ComputelessComputer merged 2 commits intomainfrom
c-branch-2
Nov 25, 2025
Merged

c-branch-2#1894
ComputelessComputer merged 2 commits intomainfrom
c-branch-2

Conversation

@ComputelessComputer
Copy link
Collaborator

No description provided.

@ComputelessComputer ComputelessComputer merged commit 3d48bec into main Nov 25, 2025
2 of 3 checks passed
@ComputelessComputer ComputelessComputer deleted the c-branch-2 branch November 25, 2025 15:53
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 25, 2025

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR introduces enhanced floating panel components for the AI note-taking product page with responsive tablet and mobile implementations, while adding minor type annotations to the OG edge function's template rendering logic.

Changes

Cohort / File(s) Summary
Type annotations in OG template rendering
apps/web/netlify/edge-functions/og.tsx
Added explicit type annotations (header: string, i: number) to the headers mapping callback in renderTemplate; control flow and logic remain unchanged.
Floating Panel feature implementation
apps/web/src/routes/_view/product/ai-notetaking.tsx
Introduced new floatingPanelTabs data structure; added FloatingPanelSection and FloatingPanelTablet components; refactored FloatingPanelDesktop to consume unified data source; enhanced FloatingPanelMobile with scroll-driven snap navigation, indicator dots, and ref-based tab control; updated FloatingPanelHeader to use shared data source; wired responsive variants to shared selectedTab state.

Sequence Diagram

sequenceDiagram
    participant User
    participant FloatingPanelContent
    participant Mobile
    participant Tablet
    participant Desktop

    User->>FloatingPanelContent: Render (selects breakpoint)
    alt Mobile Breakpoint
        FloatingPanelContent->>Mobile: Pass selectedTab, setSelectedTab, scrollRef, scrollToTab
        Mobile->>Mobile: Render snap-scrollable cards + indicator dots
        User->>Mobile: Scroll or tap indicator dot
        Mobile->>Mobile: Update selectedTab
    else Tablet Breakpoint
        FloatingPanelContent->>Tablet: Pass floatingPanelTabs data
        Tablet->>Tablet: Render horizontally-scrollable tab strip
        User->>Tablet: Select tab
        Tablet->>Tablet: Update preview content
    else Desktop Breakpoint
        FloatingPanelContent->>Desktop: Pass floatingPanelTabs[selectedTab]
        Desktop->>Desktop: Render full panel with title, description, image
        User->>Desktop: View full content
    end
    FloatingPanelContent->>FloatingPanelContent: Sync all variants via shared selectedTab state
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • ai-notetaking.tsx: Review the new floatingPanelTabs data structure design and ensure all three responsive variants (Mobile, Tablet, Desktop) correctly reference this unified source; verify state management consistency (selectedTab, scrollRef callbacks) across breakpoints and that the scroll-driven mobile navigation logic functions correctly.
  • og.tsx: Confirm the type annotations are correctly applied and don't conflict with existing downstream usage.

Possibly related PRs

Suggested reviewers

  • yujonglee
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch c-branch-2

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f94e83f and f467f84.

📒 Files selected for processing (2)
  • apps/web/netlify/edge-functions/og.tsx (1 hunks)
  • apps/web/src/routes/_view/product/ai-notetaking.tsx (5 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote ready!

Name Link
🔨 Latest commit f467f84
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote/deploys/6925d0f0202475000855cb85
😎 Deploy Preview https://deploy-preview-1894--hyprnote.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Nov 25, 2025

Deploy Preview for hyprnote-storybook ready!

Name Link
🔨 Latest commit f467f84
🔍 Latest deploy log https://app.netlify.com/projects/hyprnote-storybook/deploys/6925d0f0fa396c00073593c7
😎 Deploy Preview https://deploy-preview-1894--hyprnote-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@argos-ci
Copy link

argos-ci bot commented Nov 25, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
web (Inspect) ⚠️ Changes detected (Review) 2 changed Nov 25, 2025, 3:57 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments