Notify user after failing to start recording#715
Closed
ComputelessComputer wants to merge 5 commits intomainfrom
Closed
Notify user after failing to start recording#715ComputelessComputer wants to merge 5 commits intomainfrom
ComputelessComputer wants to merge 5 commits intomainfrom
Conversation
2 tasks
ComputelessComputer
force-pushed
the
update-listen-button-handling
branch
3 times, most recently
from
e358f97 to
ad7098f
Compare
Adds error handling to the `start` action in the `ongoingSessionStore`. The `start` action now returns a promise so that errors can be caught by callers. If an error occurs while starting the session, the store state is reset to the initial state and a new error is thrown with a descriptive message.
This commit adds error handling for when a recording session fails to start. If the session fails to start, it checks if the main window is visible and displays a toast notification with the error message. If the main window is not visible, it checks if the user has granted notification permissions and displays a notification instead. This change ensures that users are informed when a recording session fails to start, providing them with more context and guidance on how to resolve the issue.
The changes made in this commit improve the user experience when recording fails. Instead of displaying a generic error message, the app now shows a more specific notification with a clear call to action for the user to try the recording again. Additionally, the notification is now displayed using the desktop notification API, providing a more seamless and native experience for the user.
ComputelessComputer
force-pushed
the
update-listen-button-handling
branch
2 times, most recently
from
1129cd5 to
b71ea05
Compare
ComputelessComputer
force-pushed
the
update-listen-button-handling
branch
from
b71ea05 to
e567475
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
startaction in theongoingSessionStoreto return a promise and reset the store state on errors