Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal Best Leader Board Bugs #29

Open
1 of 4 tasks
fatfingers23 opened this issue Apr 22, 2024 · 0 comments
Open
1 of 4 tasks

Personal Best Leader Board Bugs #29

fatfingers23 opened this issue Apr 22, 2024 · 0 comments
Labels
good first issue Good for newcomers

Comments

@fatfingers23
Copy link
Owner

fatfingers23 commented Apr 22, 2024

Pbs show under the wrong name

Since this is done dynamically. As in if TrackScape see's a new one never recorded before, it adds it. Some activities are not right. Here is a list to keep track to fix at a later time.

  • Jad shows as Fight Caves if picked up from broadcast message. We need to combine the 2. Probably Jad(but full name) since that's how runelite backend handles it
  • Priff laps have different capitalizations for [Aa]gility Course
  • !pb sol heredit does not work. I think this is the case for many bosses spelled fully if they have spaces in their name. I think it's sending as Sol heredit and not Sol Heredit.
    • Resolved with this commit. It was the space issue checking under Sol heredit when it needed to be Sol Heredit
  • Sol Heredit and Colosseum should be merged. Colosseum comes from in game broadcasts so can record it as Sol Heredit to match RL

RSNS with _(lowbar) have trouble making it to the PB Leaderboards

Jagex sees _ and a space as the same, some lookups must be doing it with _ instead of space but with a space is recorded

Appears to be an issue with decimal best times (00:30.6)

Some show, some do not. It’s either an issue with it not storing them properly or the js function that renders it out from seconds to a more readable format

Some bosses are doubling up

It appears some bosses are doubling up, but this appears to be a whitespace issue. For example there is a Whisperer and Whisperer Should be resolved with this commit

@fatfingers23 fatfingers23 added the good first issue Good for newcomers label Apr 22, 2024
@fatfingers23 fatfingers23 changed the title Personal Best Activites Under Wrong name Personal Best Leader Board Bugs Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant