-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to convert from geodetic and spherical coordinates to Cartesian coordinats #165
Comments
In which class do you think these methods should be added? |
I see two possible ways to do this, and it might even make sense to do both. First, we could just create some generic functions in the top level namespace to do the transformations, and then to use these internally (where needed) in the ellipsoid classes. Necessary low level functionality would include
Second, we could create a method like |
Hello, I cloned the project and as usual, I always run the test before starting to edit the code. In this case, when the test is already failing due to redundancy, what do you recommend? I couldn't find any redundancy in the init.py file. Is there any related issue regarding this? |
@Phssilva see my comment on fatiando/ensaio#67 |
@MarkWieczorek I think we could have:
Since they don't rely on each other, they could also be implemented in 2 separate pull requests. |
I'm going to close this, as the linked proposal supercedes this discussion. |
In some cases, it is necessary to determine the Cartesian coordinates that correspond to a set of spherical or geodetic coordinates. The equations are trivial, and I propose adding the methods:
spherical_to_cartesian
geodetic_to_cartesian
These will be useful regarding my comments about the InSight lander....
The text was updated successfully, but these errors were encountered: