Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Title Case to the list of supported cases #65

Closed
anant-barlota opened this issue Jul 5, 2020 · 3 comments
Closed

Adding Title Case to the list of supported cases #65

anant-barlota opened this issue Jul 5, 2020 · 3 comments

Comments

@anant-barlota
Copy link

anant-barlota commented Jul 5, 2020

Hi, I was wondering if we could add an additional option of 'Title Case'. I came across its usefulness while adding csv tags to my structs.

I've written a simple code fix for it, but I'm unable to push the branch to this repo. I would appreciate any feedback on this.

@fatih
Copy link
Owner

fatih commented Jul 5, 2020

Hi @anant-barlota Can you give me an example of Title Case? Would pascalcase not be useful for you? Would be great to have some real world examples and see how it's being used.

I've written a simple code fix for it, but I'm unable to push the branch to this repo. I would appreciate any feedback on this.

The way you do at GitHub is, you create a fork of this repository, i.e: github.com/anant-barlota/gomodifytags, create a branch and then push your changes to your own fork. Then you come to this repo and you can create a PR. Let me know if anything is not clear.

@anant-barlota
Copy link
Author

anant-barlota commented Jul 5, 2020

Hi @anant-barlota Can you give me an example of Title Case? Would pascalcase not be useful for you? Would be great to have some real world examples and see how it's being used.

So I'm using a csv marshaller, that takes my structs and uses the tags for the column names. My tags are space seperated strings for better representation. Like PascalCase but space separated, basically 'Title Case'.

The way you do at GitHub is, you create a fork of this repository, i.e: github.com/anant-barlota/gomodifytags, create a branch and then push your changes to your own fork. Then you come to this repo and you can create a PR. Let me know if anything is not clear.

Oh thanks, I've never contributed on GitHub so had no clue.

@fatih
Copy link
Owner

fatih commented Sep 22, 2021

This is now fixed and merged with the release https://github.com/fatih/gomodifytags/releases/tag/v1.16.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants