-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make go_list_type configurable for each command independently #1408
Comments
(partly cross posted from #1365) Having said that, though, the defaults for each command should still be consistent. In light of #1365, what should be the criteria for deciding the default list type for each command? Making For reference, #700 introduced the use of both list types and was completed to fix #696. Use cases are always helpful, and here's one that seems to be a counter point to #1365:
As a user, I would find that surprising. What I'd want to happen is to be able to correct the formatting problem and then do |
We can go back for gofmt for location list. I think we just need a comment so next time I don't accidentally change it. If you want to work on it feel free to start. I know that you already worked on this behavior. So I think the following should apply in order:
Do you think this is clear and is worth tackling ? |
SGTM I've already started the work and should be able to finish it up soon. I was considering keeping just the single configuration value, |
I'm usually against dynamic types as it's make it hard to refactor :/ I know that Vim itself encourages it in some places. I think having |
Currently this setting is global. However we could make it better by giving the user the ability what they want to use for each command. So instead of
we could have:
This would override the command's default setting for the list.
The text was updated successfully, but these errors were encountered: