Override the :A command to toggle between go implementation code and test code.

[peterhellberg]

I’d like vim-go to have the functionality of https://github.com/benmills/vim-golang-alternate and possibly add support for optionally creating missing test files when toggling.

[fatih]

Thanks @peterhellberg for the suggestion. This is a nice feature we can add 👍

[nhooyr]

@fatih Do we ask the author for permission or can we just take it and credit him?

[peterhellberg]

The only issue on that repo is a question about what license it should have… opened on 24 Jan 2014

I wouldn’t hold my breath for a reply from @benmills, but we should at least try to contact him.

[nhooyr]

Alright, whenever you feel is good I can create the PR with the docs and everything.

[benmills]

Sounds good to me! Thanks for thinking of this @peterhellberg

[nhooyr]

Okie, i'll create a PR and stuff.

[nhooyr]

@peterhellberg do you really think we need an option to create the test file? Do you you think it should be universally enabled?

[peterhellberg]

@nhooyr I’d be happy if the test file was automatically created.

It might be a good idea to be able to disable that feature using a let, what do you think?

Edit: And now when I looked at the PR it seems like you already did that :)

[peterhellberg]

@nhooyr Is your code enabling the traditional commands :A :AV and :AS? (alternate, alternate vsplit and alternate split)

[nhooyr]

@peterhellberg oh I didn't know thats a actual thing. I just used :GoAlternate and a bunch of mappings. I can switch it to that but that might cause problems with other peoples mappings (:A is the mapping in fzf.vim for ag). Should I add a switch to turn this on then?

[nhooyr]

It's just that the other mappings (GoRun) use the same setup I implemented instead of overriding :A. There is no GoRunVertical, you instead use the mapping (go-run-vertical). And it uses a variable to decide the default way you want it. I mean if you really think its necessary, its not that hard to just add over the current code, its like 3 lines.

[nhooyr]

You can also just add this to your .vimrc

augroup go
    autocmd!
    autocmd Filetype go command! -bang A call go#alternate#Switch('edit<bang>')
    autocmd Filetype go command! AV call go#alternate#Switch('vsplit')
    autocmd Filetype go command! AS call go#alternate#Switch('split')
augroup END

[peterhellberg]

I’m just so used to using a.vim (and for vim-golang-alternate for go) for so many years now that :A and :AV is lodged in my muscle memory.

I can definitely change my .nvimrc if you want to keep the default command as GoAlternate.

[nhooyr]

lets wait and see what @fatih thinks.

[peterhellberg]

I’m going to Vietnam tomorrow and will leave my laptop at home, will be back in Sweden in a month.

@nhooyr I’m happy with letting you and @fatih decide on how to best implement this feature.

[fatih]

I've made some comments to the PR #704 I think we shouldn't create a new file at all but it should be created if a bang ! is passed. Such as :GoAlternate! , this would force to create the file. Let's discuss it in the PR.

[nhooyr]

@peterhellberg it was merged. here are the commands you need to put in your vimrc if you want your alternate commands to work.

augroup go
    autocmd!
    autocmd Filetype go command! -bang A call go#alternate#Switch(<bang>0, 'edit')
    autocmd Filetype go command! -bang AV call go#alternate#Switch(<bang>0, 'vsplit')
    autocmd Filetype go command! -bang AS call go#alternate#Switch(<bang>0, 'split')
augroup END

[fatih]

@nhooyr I've just added myself for A. I think we can add them to our doc as this is something used by many already. Mind opening a PR ;) ?

[fatih]

Closed as we have this feature now.

[nhooyr]

@fatih should I add this to the readme. It sounds like something more suited for it.

[fatih]

Readme is ok. But also add to the doc. The thing is README is getting long everytime we add a new feature and I don't want it to be very long. That's why I do a cleanup every 2-3 months. Vim users should look anything from the doc as that's is the place we should put.

[peterhellberg]

Thank you guys! I’ll update my config when I get back to Europe :)

[peterhellberg]

I’ve now updated my config and this feature works really well, but I get a vim-go: PANIC PANIC PANIC message when calling :A!

Is this the intended behavior?

[nhooyr]

No, I'll look into it.

[peterhellberg]

Note that it functions just fine, it is just an unexpected error message (possibly due to the created empty buffer not having a package line)

[nhooyr]

Yea I understood. I'm in class atm, i'll look into it at lunch.

[nhooyr]

So it only happens in empty buffers?

[peterhellberg]

@nhooyr Take your time, no stress :)

And yes, it only happens when an empty file/buffer is created.
Calling :A! on a file that has a corresponding test work just fine.

[nhooyr]

I'm not stressed, its my way of having fun :P

alright thanks.

[nhooyr]

PANIC PANIC PANIC is what gocode returns if there is an error, do you have autocomplete?

[peterhellberg]

Yes, and I guess gocode is called when the buffer is switched.

Calling :A (with no trailing !) first shows the message vim-go: couldn't find foo_test.go and then after a few hundred ms vim-go: PANIC PANIC PANIC if foo.go is empty.

[nhooyr]

I don't think that can be fixed then, its a harmless error message though.

[peterhellberg]

No, unless populating the buffer with package <name> :)

I think I found the underlying issue now, and it was that I have let g:go_auto_type_info = 1 in my config.

[nhooyr]

ah yes, that calls gocode as well.

[nhooyr]

Maybe we shouldn't print the PANIC PANIC PANIC in that case?

[peterhellberg]

It might too much of an edge case to really care about?

[nhooyr]

I meant, ignore the PANIC PANIC PANIC if g:go_auto_type_info = 1

[peterhellberg]

Probably not, but @fatih maybe want to decide on this?

[nhooyr]

Yup. but I did find a bug in the implementation of this thanks to you. it doesn't handle empty filenames.

[nhooyr]

Alright my improvements are in #758 and improvements to GoInfo in #759