fix: updating was wrongly restricted by detection timeout #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The context used in the old updateIP for setting IPs already has the timeout set for detection. The new code uses a fresh context for setting IPs.
Codecov Report
@@ Coverage Diff @@
## main #159 +/- ##
==========================================
- Coverage 79.95% 79.83% -0.13%
==========================================
Files 25 25
Lines 1312 1314 +2
==========================================
Hits 1049 1049
- Misses 259 261 +2
Partials 4 4
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The context used in the old updateIP for setting IPs already has the timeout set for detection. The new code uses a fresh context for setting IPs. I believe this fixes #147.