Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace the template engine with an in-house parser #233

Merged
merged 10 commits into from
Oct 23, 2022

Conversation

favonia
Copy link
Owner

@favonia favonia commented Oct 23, 2022

This implements #223.

@favonia favonia linked an issue Oct 23, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #233 (175f358) into main (f216a7c) will increase coverage by 0.74%.
The diff coverage is 96.55%.

@@            Coverage Diff             @@
##             main     #233      +/-   ##
==========================================
+ Coverage   84.55%   85.30%   +0.74%     
==========================================
  Files          28       29       +1     
  Lines        1774     1932     +158     
==========================================
+ Hits         1500     1648     +148     
- Misses        266      273       +7     
- Partials        8       11       +3     
Flag Coverage Δ
unittests 85.30% <96.55%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/ttl.go 100.00% <ø> (ø)
internal/domainexp/lexer.go 87.50% <87.50%> (ø)
internal/api/cloudflare.go 100.00% <100.00%> (ø)
internal/config/config.go 98.76% <100.00%> (-0.20%) ⬇️
internal/config/env.go 98.58% <100.00%> (+0.05%) ⬆️
internal/domain/domain.go 100.00% <100.00%> (ø)
internal/domainexp/parser.go 100.00% <100.00%> (ø)
internal/updater/updater.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia force-pushed the re-revamp-template branch 11 times, most recently from 31477a7 to 36880c4 Compare October 23, 2022 06:56
@favonia favonia force-pushed the re-revamp-template branch 3 times, most recently from e1b5fdb to 7ad70f0 Compare October 23, 2022 07:36
@favonia favonia force-pushed the re-revamp-template branch from 7ad70f0 to 175f358 Compare October 23, 2022 07:38
@favonia favonia merged commit 0b34720 into main Oct 23, 2022
@favonia favonia deleted the re-revamp-template branch October 23, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite/simplify the template system
1 participant