Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make the quiet mode quieter #415

Merged
merged 6 commits into from
Mar 13, 2023
Merged

fix: make the quiet mode quieter #415

merged 6 commits into from
Mar 13, 2023

Conversation

favonia
Copy link
Owner

@favonia favonia commented Mar 11, 2023

The single-run mode enabled by #411 (requested by #409) made it obvious that the quiet mode should be quieter. A few areas to improve:

  • updater version printing
  • privilege dropping
  • "Bye!"
  • config errors other than parsing templates
  • parsing errors

@favonia favonia added this to the 1.9.0 milestone Mar 11, 2023
@codecov
Copy link

codecov bot commented Mar 11, 2023

Codecov Report

Merging #415 (03b9b81) into main (9ddc185) will increase coverage by 0.49%.
The diff coverage is 55.95%.

@@            Coverage Diff             @@
##             main     #415      +/-   ##
==========================================
+ Coverage   87.71%   88.20%   +0.49%     
==========================================
  Files          33       35       +2     
  Lines        2075     2078       +3     
==========================================
+ Hits         1820     1833      +13     
+ Misses        243      234       -9     
+ Partials       12       11       -1     
Flag Coverage Δ
unittests 88.20% <55.95%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/ddns/ddns.go 0.00% <0.00%> (ø)
internal/droproot/checker.go 0.00% <0.00%> (ø)
internal/droproot/config.go 0.00% <0.00%> (ø)
internal/droproot/drop.go 0.00% <0.00%> (ø)
internal/config/config.go 100.00% <100.00%> (+1.18%) ⬆️
internal/config/env.go 98.80% <100.00%> (+0.11%) ⬆️
internal/domainexp/lexer.go 87.50% <100.00%> (ø)
internal/domainexp/parser.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia changed the title style: hide more stuff during the quiet mode style: make the quiet mode quieter Mar 12, 2023
@favonia favonia force-pushed the quieter-quiet-mode branch from d4a5aad to bb7be89 Compare March 13, 2023 05:39
@favonia favonia force-pushed the quieter-quiet-mode branch from bb7be89 to a02b386 Compare March 13, 2023 05:47
@favonia favonia force-pushed the quieter-quiet-mode branch from a02b386 to eb8aa8f Compare March 13, 2023 05:49
@favonia favonia force-pushed the quieter-quiet-mode branch from 68c8c8d to 03b9b81 Compare March 13, 2023 06:00
@favonia favonia changed the title style: make the quiet mode quieter fix: make the quiet mode quieter Mar 13, 2023
@favonia favonia merged commit 92a4462 into main Mar 13, 2023
@favonia favonia deleted the quieter-quiet-mode branch March 13, 2023 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant