Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine the new custom provider url:XXX #576

Merged
merged 4 commits into from
Sep 10, 2023
Merged

Conversation

favonia
Copy link
Owner

@favonia favonia commented Sep 10, 2023

Closes #570.

@codecov
Copy link

codecov bot commented Sep 10, 2023

Codecov Report

Merging #576 (095f9a7) into main (19a838a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #576      +/-   ##
==========================================
+ Coverage   87.83%   87.96%   +0.13%     
==========================================
  Files          44       44              
  Lines        2178     2202      +24     
==========================================
+ Hits         1913     1937      +24     
  Misses        256      256              
  Partials        9        9              
Flag Coverage Δ
unittests 87.96% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
internal/config/env_provider.go 100.00% <100.00%> (ø)
internal/provider/custom.go 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@favonia favonia merged commit d80784e into main Sep 10, 2023
@favonia favonia deleted the refine-url-provider branch September 10, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine the new url IP provider
1 participant