Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(api): test for package api #61

Merged
merged 5 commits into from
Aug 6, 2021
Merged

test(api): test for package api #61

merged 5 commits into from
Aug 6, 2021

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 5, 2021

Really close #57.

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #61 (20d4fe1) into main (d5acc7d) will increase coverage by 10.86%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #61       +/-   ##
===========================================
+ Coverage   41.48%   52.34%   +10.86%     
===========================================
  Files           7        7               
  Lines         270      277        +7     
===========================================
+ Hits          112      145       +33     
+ Misses        158      132       -26     
Flag Coverage Δ
unittests 52.34% <40.00%> (+10.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/cloudflare.go 16.98% <8.69%> (+16.98%) ⬆️
internal/api/fqdn.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5acc7d...20d4fe1. Read the comment docs.

@favonia favonia merged commit c53e900 into main Aug 6, 2021
@favonia favonia deleted the test-api branch August 6, 2021 02:08
favonia added a commit that referenced this pull request Aug 6, 2021
* test(api): CloudflareAuth.New

* fix(api): always use ASCII forms to access Cloudflare API

* test(api): update the test of api

* docs(api): remove the bogus comment

* test(api): rename test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the domain normalization
1 participant