Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): clear a WAF list when it cannot be deleted #908

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Conversation

favonia
Copy link
Owner

@favonia favonia commented Aug 29, 2024

Close #893.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 98.55596% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.59%. Comparing base (d7b917b) to head (57e57fa).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ddns/ddns.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #908      +/-   ##
==========================================
+ Coverage   95.50%   95.59%   +0.08%     
==========================================
  Files          59       61       +2     
  Lines        2535     2586      +51     
==========================================
+ Hits         2421     2472      +51     
  Misses        104      104              
  Partials       10       10              
Flag Coverage Δ
unittests 95.59% <98.55%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@favonia favonia force-pushed the clear-lists branch 9 times, most recently from 5812f79 to 39c7eeb Compare August 29, 2024 16:03
@favonia favonia merged commit 1acf11d into main Aug 29, 2024
10 checks passed
@favonia favonia deleted the clear-lists branch August 29, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clear WAF lists when deletion fails
1 participant