Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): keep leading dots after the beginning * is removed #97

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

favonia
Copy link
Owner

@favonia favonia commented Oct 18, 2021

This is to handle some obscure corner cases that probably never show up in reality. Previously, for the domain *....a.com the tool will immediately try a.com and com and so on. Now it would try ...a.com, ..a.com, and .a.com before a.com and com.

@codecov
Copy link

codecov bot commented Oct 18, 2021

Codecov Report

Merging #97 (574dc70) into main (09f4dfe) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   78.63%   78.63%           
=======================================
  Files          24       24           
  Lines        1212     1212           
=======================================
  Hits          953      953           
  Misses        255      255           
  Partials        4        4           
Flag Coverage Δ
unittests 78.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/api/domain.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09f4dfe...574dc70. Read the comment docs.

@favonia favonia merged commit bb2da38 into main Oct 18, 2021
@favonia favonia deleted the keep-leading-dots branch October 18, 2021 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant