Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Effort Value yields to all Pokémon #444

Merged
merged 12 commits into from
Sep 6, 2021
Merged

Conversation

favna
Copy link
Member

@favna favna commented Apr 10, 2021

TODO:

  • EV yields Generation 8
  • EV yields Generation 7
  • EV yields Generation 6
  • EV yields Generation 5
  • EV yields Generation 4
  • EV yields Generation 3
  • EV yields Generation 2
  • EV yields Generation 1
  • Process review comments

Copy link
Member Author

@favna favna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For testing you can use this query. Replace the pokemon at the bottom with any other and it will give the proper results, including all evolutions and pre-evolutions if applicable.

fragment evYields on EvYieldsEntry {
  hp
  attack
  defense
  specialattack
  specialdefense
  speed
}

fragment dexdetails on DexDetails {
  num
  species
  evYields {
    ...evYields
  }
}

fragment evolutions on DexDetails {
  evolutions {
    ...dexdetails
    evolutions {
      ...dexdetails
    }
  }
  preevolutions {
    ...dexdetails
    preevolutions {
      ...dexdetails
    }
  }
}

{
  getPokemonDetailsByName(pokemon: scorbunny, reverse: true, take: 1) {
    ...dexdetails
    ...evolutions
  }
}

src/utils/pokemon.d.ts Outdated Show resolved Hide resolved
src/services/DexService.ts Outdated Show resolved Hide resolved
src/services/DexService.ts Outdated Show resolved Hide resolved
src/structures/DexEntry.ts Outdated Show resolved Hide resolved
@favna favna changed the base branch from main to staging September 5, 2021 13:49
@favna favna force-pushed the feat/add-ev-yields branch 2 times, most recently from ccf7e56 to ddcf1d9 Compare September 5, 2021 13:56
- feat: add all of the service level stuff
- build: open propert port in dev container
- build: update devcontainer extensions
- feat: add evYields for gen7
- fix: minior-meteor didn't have the `otherFormes` property.
@favna favna changed the title [WIP] feat: add Effort Value yields to all Pokémon feat: add Effort Value yields to all Pokémon Sep 6, 2021
@favna favna marked this pull request as ready for review September 6, 2021 18:43
@favna favna self-assigned this Sep 6, 2021
@favna favna merged commit bc83812 into staging Sep 6, 2021
@favna favna deleted the feat/add-ev-yields branch September 6, 2021 19:03
favna added a commit that referenced this pull request Sep 6, 2021
Co-authored-by: Ed L <beartechtalks@gmail.com>
Co-authored-by: nandhagk <nandhagopi@gmail.com>
favna added a commit that referenced this pull request Sep 6, 2021
Co-authored-by: Ed L <beartechtalks@gmail.com>
Co-authored-by: nandhagk <nandhagopi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants