Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URGENT: React Video Recorder broken on Chrome latest + Safari latest #130

Closed
catoenm opened this issue Aug 3, 2021 · 3 comments
Closed

Comments

@catoenm
Copy link
Contributor

catoenm commented Aug 3, 2021

React Video Recorder is crashing on the latest version of chrome. I've tried versions 3.18.4, 3.18.2, 3.17.2.

The following is the error message received any time the user stops recording.

image

@catoenm catoenm changed the title URGENT: React Video Recorder broken on Chrome latest URGENT: React Video Recorder broken on Chrome latest + Safari latest Aug 3, 2021
@DaveFerBear
Copy link

Same issue here. Current version in sandbox is broken: https://0d26g.csb.app/

@catoenm
Copy link
Contributor Author

catoenm commented Aug 3, 2021

Seems to be an issue with the latest chrome update.

https://chromereleases.googleblog.com/

@catoenm
Copy link
Contributor Author

catoenm commented Aug 3, 2021

This seems to be a problem with decoding schemas in EBML.

legokichi/ts-ebml#33 (comment)

The following fixes the issue for me.

-      const elements = decoder.decode(buffer)
+      let elements = decoder.decode(buffer)
+      // see https://github.com/legokichi/ts-ebml/issues/33#issuecomment-888800828
+      const validEmlType = ['m', 'u', 'i', 'f', 's', '8', 'b', 'd']
+      elements = elements?.filter((elm) => validEmlType.includes(elm.type))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants