Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Value should be Json.Encode.Value #28

Open
anup-the-magic opened this issue Jun 14, 2017 · 1 comment
Open

Documentation: Value should be Json.Encode.Value #28

anup-the-magic opened this issue Jun 14, 2017 · 1 comment
Assignees

Comments

@anup-the-magic
Copy link

Link Value to Json.Encode.Value and be explicit about what it is in documentation

@50kudos
Copy link

50kudos commented Jun 16, 2017

Actually, I could add more related thing. Or let me know if I misunderstood something.
According to http://package.elm-lang.org/packages/fbonetti/elm-phoenix-socket/2.2.0/Phoenix-Channel :

Value of any function that begins with on e.g. onClose, onError, onJoin and onJoinError should be the Json.Decode.Value type because the value comes from the outside world. I know that Json.Decode.Value is actually Json.Encode.Value under the hood, but it is confusing.

@maxstr maxstr self-assigned this Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants