Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to work with Fedora-Camel 5.0.0 #143

Merged
merged 3 commits into from
Mar 15, 2019

Conversation

whikloj
Copy link
Contributor

@whikloj whikloj commented Mar 9, 2019

JIRA Ticket: https://jira.duraspace.org/browse/FCREPO-2787

Related PR: fcrepo-exts/fcrepo-camel#150

What does this Pull Request do?

Most of this is @dbernstein's work from before, I just dragged it across a line.

What's new?

I checked out a bunch of things from @dbernstein's update-fcrepo-parent-pom branch but stuck with the older versions of dependencies.

How should this be tested?

Should build and then you could try testing it out. I am going to try it in fcrepo-vagrant soon.

Additional Notes:

Example:

  • Does this change require documentation to be updated? no
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

Interested parties

@peichman-umd @birkland @dbernstein or any other interested @fcrepo4/committers

@whikloj
Copy link
Contributor Author

whikloj commented Mar 9, 2019

I hope this works for you all, but it passed on my machine and I was like James Brown dancing

@whikloj
Copy link
Contributor Author

whikloj commented Mar 9, 2019

Failure is due to log length, log length is due to seemingly a tonne of duplicate class in the Fedora war.

@whikloj
Copy link
Contributor Author

whikloj commented Mar 9, 2019

So yeah, Shiro seems to have classes included in multiple places or maybe its just the way Jetty scans but I started to try and exclude some artifacts in fcrepo-webapp and realized I had to pretty much exclude everything. So either we have waaay to much of shiro included as dependencies or Jetty 9.3 is just causing trouble

@whikloj
Copy link
Contributor Author

whikloj commented Mar 9, 2019

Yeah I maybe I don't understand what Shiro is trying to do but they have the same classes in different packages and then they have dependencies between those packages (ie. shiro-config-ogdl has a dependency on shiro-config-core)?

[/Users/whikloj/.m2/repository/org/apache/shiro/shiro-config-ogdl/1.4.0] 
> unzip -t shiro-config-ogdl-1.4.0.jar | grep ConfigurationException -
    testing: org/apache/shiro/config/ConfigurationException.class   OK

[/Users/whikloj/.m2/repository/org/apache/shiro/shiro-config-core/1.4.0] 
> unzip -t shiro-config-core-1.4.0.jar | grep ConfigurationException -
    testing: org/apache/shiro/config/ConfigurationException.class   OK

@whikloj
Copy link
Contributor Author

whikloj commented Mar 9, 2019

Ok this is an open issue for Shiro https://issues.apache.org/jira/browse/SHIRO-632

@dbernstein
Copy link
Contributor

dbernstein commented Mar 11, 2019

@whikloj : I'm going to put a picture of you on my desk and recall the good that you have done here each and every day. YES! It works and has taught me the value of restraint when it comes to unnecessary dependency updates.

@dbernstein
Copy link
Contributor

@whikloj: Looks like it needs a rebasing as well when you get a chance.

@whikloj
Copy link
Contributor Author

whikloj commented Mar 11, 2019

@dbernstein I'll rebase this, I also want to see if I can bump the camel version 2.20 as that would alleviate the security warnings.

I'll also note it wasn't necessarily the dependencies causing the problems, two of the tests in fcrepo-service-camel were actually failing.

We used to emit 2 messages for a CREATE (one for the item and one for the parent). But now we emit 3 (one for item, one for parent and one for versions container).

in order to prevent the log from growing too long for travis (due to shiro bug that produces unnecessary WARNING messages).
@peichman-umd peichman-umd merged commit 6beb0ef into fcrepo-exts:master Mar 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants