-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to work with Fedora-Camel 5.0.0 #143
Conversation
Failure is due to log length, log length is due to seemingly a tonne of duplicate class in the Fedora war. |
So yeah, Shiro seems to have classes included in multiple places or maybe its just the way Jetty scans but I started to try and exclude some artifacts in fcrepo-webapp and realized I had to pretty much exclude everything. So either we have waaay to much of shiro included as dependencies or Jetty 9.3 is just causing trouble |
Yeah I maybe I don't understand what Shiro is trying to do but they have the same classes in different packages and then they have dependencies between those packages (ie.
|
Ok this is an open issue for Shiro https://issues.apache.org/jira/browse/SHIRO-632 |
@whikloj : I'm going to put a picture of you on my desk and recall the good that you have done here each and every day. YES! It works and has taught me the value of restraint when it comes to unnecessary dependency updates. |
@whikloj: Looks like it needs a rebasing as well when you get a chance. |
@dbernstein I'll rebase this, I also want to see if I can bump the camel version 2.20 as that would alleviate the security warnings. I'll also note it wasn't necessarily the dependencies causing the problems, two of the tests in fcrepo-service-camel were actually failing. We used to emit 2 messages for a CREATE (one for the item and one for the parent). But now we emit 3 (one for item, one for parent and one for versions container). |
in order to prevent the log from growing too long for travis (due to shiro bug that produces unnecessary WARNING messages).
JIRA Ticket: https://jira.duraspace.org/browse/FCREPO-2787
Related PR: fcrepo-exts/fcrepo-camel#150
What does this Pull Request do?
Most of this is @dbernstein's work from before, I just dragged it across a line.
What's new?
I checked out a bunch of things from @dbernstein's update-fcrepo-parent-pom branch but stuck with the older versions of dependencies.
How should this be tested?
Should build and then you could try testing it out. I am going to try it in fcrepo-vagrant soon.
Additional Notes:
Example:
Interested parties
@peichman-umd @birkland @dbernstein or any other interested @fcrepo4/committers