Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CE 3.5.0 async cancelation semantics #1181

Closed
Jasper-M opened this issue Apr 3, 2023 · 3 comments
Closed

CE 3.5.0 async cancelation semantics #1181

Jasper-M opened this issue Apr 3, 2023 · 3 comments

Comments

@Jasper-M
Copy link

Jasper-M commented Apr 3, 2023

I think fs2-kafka will require some changes to accommodate the new async cancelation semantics in the upcoming CE 3.5.0.

For instance this timeout will probably be rendered useless. Also I suspect that currently this timeout only cancels the waiting on the callback but will leak the actual hanging commit, which is what those new semantics are guarding against.
@bplommer
Copy link
Member

Thanks for flagging this! I'm on it.

@bplommer
Copy link
Member

Also I suspect that currently this timeout only cancels the waiting on the callback but will leak the actual hanging commit, which is what those new semantics are guarding against.

Yes, you're right - unfortunately I don't think there's anything we can do about that unless we revert to using the commitSync method which has an optional timeout parameter.

@bplommer bplommer mentioned this issue Apr 11, 2023
Merged
@Jasper-M
Copy link
Author

I guess this is fixed, but github didn't close it for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jasper-M @bplommer