-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade 3.x to CE 3.5.1 / fs2 3.8.0 #1234
Comments
While the CE version hasn't been upgraded yet, the library should already be compatible with the new cancelation stuff, as of #1187. |
Ah yes, I deployed yesterday with CE 3.5.1 and fs2-kafka 3.0.1 and everything seems to be going well (touch wood). I'd still be happy to help with anything if you'd like it :) |
My organization is interested in this upgrade as 3.5.1 offers the ability to override |
@aartigao, hi! Thank you for updating the libraries. Are you planning to make a release anytime soon? It seems like a lot of people would be interested in this update. |
Yup, that's the intention. But I want to make sure I don't mess with anything and have support from the core maintainers 😅 |
Hello! I'm working on some dependency updates for $work and fs2-kafka is keeping us on cats-effect 3.4.11 (aka before the async cancellation changes) and fs2 3.6.1
I noticed that CE + fs2 upgrades are ignored in the scala-steward dependencies for 3.x, and I found a TODO regarding the update:
fs2-kafka/modules/core/src/main/scala/fs2/kafka/KafkaProducer.scala
Lines 208 to 209 in e4376d1
Is there a plan or anything in progress for that version bump yet? If not (and if it would be helpful) I could see how far I get and open up a PR? Since they were explicitly ignored I didn't want to jump in, in case I'm missing important context
The text was updated successfully, but these errors were encountered: