Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use single-threaded execution context for consumers #582

Closed
bplommer opened this issue Apr 8, 2021 · 1 comment
Closed

Use single-threaded execution context for consumers #582

bplommer opened this issue Apr 8, 2021 · 1 comment
Milestone
v2.0.0

Comments

@bplommer
Copy link
Member

bplommer commented Apr 8, 2021

The Java Consumer isn't safe for concurrent access by multiple threads. KafkaConsumerActor should prevent this from happening, but there have been reports of cases where it doesn't when using a non-default blocker with fs2-kafka 1.x. To guard against this we should use a single-threaded ExecutionContext for blocking operations on he consumer in v2.x. We should also consider deprecating withBlocker in v1.x, since a single-threaded blocker should always be used.
@bplommer bplommer added this to the v2.0.0 milestone Apr 8, 2021
@bplommer bplommer mentioned this issue Apr 8, 2021
Merged
@bplommer
Copy link
Member Author

bplommer commented Apr 9, 2021

Resolved by #584

@bplommer bplommer closed this as completed Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
v2.0.0
Development

No branches or pull requests
1 participant
@bplommer