Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded references to providers and stores #1605

Closed
woop opened this issue Jun 1, 2021 · 3 comments
Closed

Remove hardcoded references to providers and stores #1605

woop opened this issue Jun 1, 2021 · 3 comments

Comments

@woop
Copy link
Member

woop commented Jun 1, 2021

As per https://docs.google.com/document/d/1MD0aS2_hGzd1tJ7DNjE3NgEtcuekh3O06OeQ9aavylY/edit#, we need to ensure that there aren't any hardcoded references in our code to Provider or Store implementations.

@achals
Copy link
Member

achals commented Jun 11, 2021

@woop just to be clear you mean that we shouldn't be hardcoding to any specific instance of a store or a provider, right?

@woop
Copy link
Member Author

woop commented Jun 11, 2021

Yea, so for example this stands in the way of generalizing our code. It requires us to hardcode new providers. So this issue is just tracking a scan through our codebase to identify any of these hardcoded references and to remove them somehow.

@woop
Copy link
Member Author

woop commented Aug 18, 2021

This card is done.

@woop woop closed this as completed Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants