Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FeatureViews creation time #1933

Closed
amommendes opened this issue Oct 12, 2021 · 1 comment · Fixed by #1952
Closed

FeatureViews creation time #1933

amommendes opened this issue Oct 12, 2021 · 1 comment · Fixed by #1952
Labels

Comments

@amommendes
Copy link
Contributor

Expected Behavior

Feature views should have the creation time (i.e., created_timestamp) at the first feast apply

Current Behavior

Features Views do not have creation time at feature view creation

Steps to reproduce

feast init fs
cd fs
feast apply
feast registry-dump
{
  "spec": {
    "name": "driver_id",
    "valueType": "INT64",
    "description": "driver id",
    "joinKey": "driver_id"
  },
  "meta": {}
}
{
  "spec": {
    "name": "driver_hourly_stats",
    "entities": [
      "driver_id"
    ],
    "features": [
      {
        "name": "conv_rate",
        "valueType": "FLOAT"
      },
      {
        "name": "acc_rate",
        "valueType": "FLOAT"
      },
      {
        "name": "avg_daily_trips",
        "valueType": "INT64"
      }
    ],
    "ttl": "86400s",
    "batchSource": {
      "type": "BATCH_FILE",
      "eventTimestampColumn": "event_timestamp",
      "createdTimestampColumn": "created",
      "fileOptions": {
        "fileUrl": "/home/user/fs/data/driver_stats.parquet"
      },
      "dataSourceClassType": "feast.infra.offline_stores.file_source.FileSource"
    },
    "online": true
  },
  "meta": {}

Note that meta is empty.

Specifications

  • Version: 0.12+
  • Platform: Ubuntu 20.04.3 LTS

Possible Solution

Check if the feature view already have a creation date timpstamp (feature_view.created_timestamp) and then add datetime.now() if necessary. Possibly in the apply feature view method

@achals achals added good first issue Good for newcomers priority/p1 labels Oct 14, 2021
@achals
Copy link
Member

achals commented Oct 14, 2021

Thanks for the report @amommendes - we'd be happy to review a PR if you'd like to take this on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants