Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Print Method in Feast CLI #211

Closed
davidheryanto opened this issue Jun 12, 2019 · 1 comment
Closed

Fix Print Method in Feast CLI #211

davidheryanto opened this issue Jun 12, 2019 · 1 comment

Comments

@davidheryanto
Copy link
Collaborator

Expected Behavior

Unit test in feast cli should pass every time

Current Behavior

Example failure:
http://prow.feast.ai/view/gcs/feast-templocation-kf-feast/pr-logs/pull/gojek_feast/208/unit-test-cli/1138606091794386947

Unit test will fail occasionally. This is due to mismatched expectation between the actual functionality in the cli and the unit test. Test expects the printed output of the spec to be ordered but the cli data structure to store some values in spec data (i.e. map data structure) does not ensure order.

Possible Solution

Either it's okay for the printed output of CLI to not be in order (in this case, the test case need to be updated) or modify the data structure used in CLI to store spec to support ordered iteration.

Steps to reproduce

git clone https://github.com/gojek/feast
cd feast
# Need to run this command many times (e.g. 50 times) to observe the error 
go test -v ./cli/feast/...

Specifications

@woop
Copy link
Member

woop commented Sep 1, 2019

This issue isn't relevant any more due to changes in Feast 0.3.0. The Feast CLI is being rewritten in Python.

@woop woop closed this as completed Sep 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants