Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feast ui not working behind proxy #3011

Closed
bskbgood opened this issue Aug 4, 2022 · 2 comments · Fixed by #3428
Closed

feast ui not working behind proxy #3011

bskbgood opened this issue Aug 4, 2022 · 2 comments · Fixed by #3428
Labels
kind/bug priority/p2 wontfix This will not be worked on

Comments

@bskbgood
Copy link

bskbgood commented Aug 4, 2022

Expected Behavior

Feast UI should be able to load up behind proxy

Current Behavior

Feast UI not loaded behind proxy

Steps to reproduce

Specifications

  • Version: 0.23.0
  • Platform: Linux
  • Subsystem:

Possible Solution

Allow user to pass root_path when initialize FastAPI.

E.g.

from fastapi import FastAPI, Request

app = FastAPI(root_path="/api/v1")


@app.get("/app")
def read_main(request: Request):
    return {"message": "Hello World", "root_path": request.scope.get("root_path")}
@adchia
Copy link
Collaborator

adchia commented Aug 6, 2022

would you mind contributing a fix for this? Thanks!

@stale
Copy link

stale bot commented Dec 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Dec 16, 2022
@stale stale bot closed this as completed Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug priority/p2 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants