Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade protobuf past version 4 #3101

Closed
chhabrakadabra opened this issue Aug 18, 2022 · 1 comment · Fixed by #3103
Closed

Upgrade protobuf past version 4 #3101

chhabrakadabra opened this issue Aug 18, 2022 · 1 comment · Fixed by #3103
Assignees
Labels
kind/feature New feature or request priority/p1

Comments

@chhabrakadabra
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Feast pins protobuf to <4. This means that for M1 Apple machines, we have to employ some hacks. It would be nice to not have to do that. Also maintaining an upper bound on a popular library means that installing Feast alongside other libraries involves friction.

Describe the solution you'd like

Ideally, we remove the upper bound for protobuf in setup.py. It seems like the breaking changes are pretty minor: https://developers.google.com/protocol-buffers/docs/news/2022-05-06#python-updates

Describe alternatives you've considered

N/A

@chhabrakadabra chhabrakadabra added the kind/feature New feature or request label Aug 18, 2022
@kevjumba kevjumba self-assigned this Aug 18, 2022
@kevjumba
Copy link
Collaborator

hey @chhabrakadabra, this is actually not possible as of now since we have 2 packages(tensorflow-metadata) and grpcio that have their own caps for under protobuf version 4. I am going to relax the protobuf dependency for now but the version will not rise above 4 due to these packages.

Both grpcio-tools and tensorflow-metadata are the latest version so there's nothing we can really do until they update their dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request priority/p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants