Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove bad snowflake offline store method #3204

Merged

Conversation

sfc-gh-madkins
Copy link
Collaborator

@sfc-gh-madkins sfc-gh-madkins commented Sep 10, 2022

Signed-off-by: Miles Adkins miles.adkins@snowflake.com

What this PR does / why we need it:

Removes faulty retrieval method that doesnt incorporate on-demand feature views

Which issue(s) this PR fixes:

Fixes #

Signed-off-by: Miles Adkins <miles.adkins@snowflake.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2022

Codecov Report

Base: 67.02% // Head: 75.70% // Increases project coverage by +8.68% 🎉

Coverage data is based on head (a5a0e1b) compared to base (c19d640).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3204      +/-   ##
==========================================
+ Coverage   67.02%   75.70%   +8.68%     
==========================================
  Files         175      211      +36     
  Lines       15940    17919    +1979     
==========================================
+ Hits        10683    13566    +2883     
+ Misses       5257     4353     -904     
Flag Coverage Δ
integrationtests 66.86% <ø> (-0.16%) ⬇️
unittests 57.91% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
sdk/python/feast/infra/offline_stores/snowflake.py 94.46% <ø> (+1.16%) ⬆️
...on/feast/infra/materialization/snowflake_engine.py 92.09% <0.00%> (-0.47%) ⬇️
...thon/feast/infra/online_stores/contrib/postgres.py 32.69% <0.00%> (ø)
.../feature_repos/universal/online_store/cassandra.py 42.85% <0.00%> (ø)
...ib/trino_offline_store/test_config/manual_tests.py 33.33% <0.00%> (ø)
...line_stores/contrib/postgres_repo_configuration.py 100.00% <0.00%> (ø)
...ores/contrib/trino_offline_store/trino_type_map.py 6.66% <0.00%> (ø)
.../online_stores/contrib/hbase_repo_configuration.py 100.00% <0.00%> (ø)
...s/contrib/trino_offline_store/tests/data_source.py 17.64% <0.00%> (ø)
...tion/feature_repos/universal/online_store/hbase.py 50.00% <0.00%> (ø)
... and 101 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@felixwang9817 felixwang9817 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: felixwang9817, sfc-gh-madkins

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@feast-ci-bot feast-ci-bot merged commit dfdd0ca into feast-dev:master Sep 12, 2022
@sfc-gh-madkins sfc-gh-madkins deleted the snowflake_offline_retrieval branch September 19, 2022 19:56
felixwang9817 pushed a commit that referenced this pull request Sep 20, 2022
# [0.25.0](v0.24.0...v0.25.0) (2022-09-20)

### Bug Fixes

* Broken Feature Service Link ([#3227](#3227)) ([e117082](e117082))
* Feature-server image is missing mysql dependency for mysql registry ([#3223](#3223)) ([ae37b20](ae37b20))
* Fix handling of TTL in Go server ([#3232](#3232)) ([f020630](f020630))
* Fix materialization when running on Spark cluster. ([#3166](#3166)) ([175fd25](175fd25))
* Fix push API to respect feature view's already inferred entity types ([#3172](#3172)) ([7c50ab5](7c50ab5))
* Fix release workflow ([#3144](#3144)) ([20a9dd9](20a9dd9))
* Fix Shopify timestamp bug and add warnings to help with debugging entity registration ([#3191](#3191)) ([de75971](de75971))
* Handle complex Spark data types in SparkSource ([#3154](#3154)) ([5ddb83b](5ddb83b))
* Local staging location provision ([#3195](#3195)) ([cdf0faf](cdf0faf))
* Remove bad snowflake offline store method ([#3204](#3204)) ([dfdd0ca](dfdd0ca))
* Remove opening file object when validating S3 parquet source ([#3217](#3217)) ([a906018](a906018))
* Snowflake config file search error ([#3193](#3193)) ([189afb9](189afb9))
* Update Snowflake Online docs ([#3206](#3206)) ([7bc1dff](7bc1dff))

### Features

* Add `to_remote_storage` functionality to `SparkOfflineStore` ([#3175](#3175)) ([2107ce2](2107ce2))
* Add ability to give boto extra args for registry config ([#3219](#3219)) ([fbc6a2c](fbc6a2c))
* Add health endpoint to py server ([#3202](#3202)) ([43222f2](43222f2))
* Add snowflake support for date & number with scale ([#3148](#3148)) ([50e8755](50e8755))
* Add tag kwarg to set Snowflake online store table path ([#3176](#3176)) ([39aeea3](39aeea3))
* Add workgroup to athena offline store config ([#3139](#3139)) ([a752211](a752211))
* Implement spark materialization engine ([#3184](#3184)) ([a59c33a](a59c33a))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants