Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL Registry + caching is missing the function: list_validation_references( #3408

Closed
sfc-gh-madkins opened this issue Dec 21, 2022 · 1 comment · Fixed by #3436
Closed

SQL Registry + caching is missing the function: list_validation_references( #3408

sfc-gh-madkins opened this issue Dec 21, 2022 · 1 comment · Fixed by #3436
Assignees
@adchia
Labels
kind/bug priority/p2

Comments

@sfc-gh-madkins
Copy link
Collaborator

When adding the caching code to the Snowflake Registry, I noticed that the SQL Registry is missing a GET function for VALIDATION REFERENCES

Expected Behavior

THIS WORKS

store.get_validation_references()

THIS SHOULD WORK TOO

store.list_validation_references()

Current Behavior

THIS DOESNT WORK

store.list_validation_references()

Steps to reproduce

Specifications

  • Version:
  • Platform:
  • Subsystem:

Possible Solution
@sfc-gh-madkins
Copy link
Collaborator Author

Same goes for registry.py

@amommendes amommendes mentioned this issue Jan 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adchia adchia

Labels
kind/bug priority/p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Adding list_validation_references for default and sql registry amommendes/feast
2 participants
@adchia @sfc-gh-madkins