schema has duplicate fields

[hao-affirm]

Expected Behavior

feature_view.schema has no duplicate fields

Current Behavior

feature_view.schema has no duplicate fields

Steps to reproduce

Specifications

• Version:
• Platform:
• Subsystem:

Possible Solution

in feature_view:

    def schema(self) -> List[Field]:
        return list(set(self.entity_columns + self.features))

[felixwang9817]

@hao-affirm would you mind sharing the feature view definition that led to duplicate fields shared between self.entity_columns and self.features?

I'm slightly surprised by that, since I thought our inference process would place each Field in either self.entity_columns or self.features, but not both

[hao-affirm]

feast/sdk/python/feast/feature_view.py

Line 261 in 2f7c4ed

def schema(self) -> List[Field]:

and

feast/sdk/python/feast/feature_view.py

Line 171 in 2f7c4ed

for field in schema:

i think both entity_column and features will append the field, if the field is defined in both entities and schema