Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove top-level grpc import in cli #4107

Merged
merged 1 commit into from
Apr 17, 2024
Merged

fix: Remove top-level grpc import in cli #4107

merged 1 commit into from
Apr 17, 2024

Conversation

tokoko
Copy link
Collaborator

@tokoko tokoko commented Apr 17, 2024

What this PR does / why we need it:

Removes top-level grpc import in cli.

@tokoko
fix grpc import in cli
b66fea5 
Signed-off-by: tokoko <togurg14@freeuni.edu.ge>
@lokeshrangineni
Copy link
Contributor

LGTM

@HaoXuAI HaoXuAI merged commit 4362b6c into feast-dev:master Apr 17, 2024
21 checks passed
@tokoko tokoko deleted the fix-grpc-import branch April 17, 2024 06:57
jeremyary pushed a commit that referenced this pull request Apr 17, 2024
@feast-ci-bot
chore(release): release 0.37.0
0fb2351 
# [0.37.0](v0.36.0...v0.37.0) (2024-04-17)

### Bug Fixes

* Pgvector patch ([#4103](#4103)) ([5c4a9c5](5c4a9c5))
* Remove top-level grpc import in cli ([#4107](#4107)) ([4362b6c](4362b6c))

### Features

* Add tags to dynamodb config ([#4100](#4100)) ([b08b8d5](b08b8d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoXuAI HaoXuAI HaoXuAI approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tokoko @lokeshrangineni @HaoXuAI @sudohainguyen