Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional params to repo config for Snowflake private key authentication #4204

Closed
ArijeetC opened this issue May 15, 2024 · 0 comments · Fixed by #4205
Closed

Add optional params to repo config for Snowflake private key authentication #4204

ArijeetC opened this issue May 15, 2024 · 0 comments · Fixed by #4205
Labels
kind/feature New feature or request

Comments

@ArijeetC
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When using private key authentication for Snowflake, the private key path and passphrase params must be defined in a config file and then the config file path must be added in the feature_store.yaml file (#2482 (comment)).

Instead of creating a separate config INI file just for these 2 params, they could be simply added in the feature_store.yaml file along with the other params.

Describe the solution you'd like
Adding optional params private_key and private_key_passphrase to the Snowflake config classes (SnowflakeRegistryConfig, SnowflakeOnlineStoreConfig, SnowflakeOfflineStoreConfig, SnowflakeMaterializationEngineConfig) so that they can be used in feature_store.yaml file directly.

Describe alternatives you've considered
None

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant