Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added deadline to gRPC Java client #4217

Conversation

acevedosharp
Copy link
Contributor

@acevedosharp acevedosharp commented May 21, 2024

What this PR does / why we need it:

Added configurable deadlines for the Feast Java gRPC client. We need it because clients could otherwise get stuck forever waiting for the feature server to respond, and we should make it simpler for users of this library to implement retries and timeouts; especially when it's already supported in gRPC by default.

Which issue(s) this PR fixes:

N/A

Fixes

N/A

Signed-off-by: Jose Acevedo <sharp.acevedo@gmail.com>
@acevedosharp acevedosharp force-pushed the java-grpc-client-add-deadline branch from c5542d5 to e53b502 Compare May 22, 2024 21:23
@tokoko
Copy link
Collaborator

tokoko commented May 25, 2024

/lgtm

@franciscojavierarceo franciscojavierarceo merged commit ff429c9 into feast-dev:master May 26, 2024
23 checks passed
franciscojavierarceo pushed a commit that referenced this pull request May 27, 2024
Added deadline to gRPC Java Client

Signed-off-by: Jose Acevedo <sharp.acevedo@gmail.com>
franciscojavierarceo pushed a commit that referenced this pull request Jun 18, 2024
# [0.39.0](v0.38.0...v0.39.0) (2024-06-18)

### Bug Fixes

* Feast UI importlib change ([#4248](#4248)) ([5d486b8](5d486b8))
* Feature server no_feature_log argument error ([#4255](#4255)) ([15524ce](15524ce))
* Feature UI Server image won't start in an OpenShift cluster ([#4250](#4250)) ([4891f76](4891f76))
* Handles null values in data during GO Feature retrieval ([#4274](#4274)) ([c491e57](c491e57))
* Make Java gRPC client use timeouts as expected ([#4237](#4237)) ([f5a37c1](f5a37c1))
* Remove self assignment code line. ([#4238](#4238)) ([e514f66](e514f66))
* Set default values for feature_store.serve() function ([#4225](#4225)) ([fa74438](fa74438))

### Features

* Add online_read_async for dynamodb ([#4244](#4244)) ([b5ef384](b5ef384))
* Add the ability to list objects by `tags` ([#4246](#4246)) ([fbf92da](fbf92da))
* Added deadline to gRPC Java client ([#4217](#4217)) ([ff429c9](ff429c9))
* Adding vector search for sqlite ([#4176](#4176)) ([2478831](2478831))
* Change get_online_features signature, move online retrieval functions to utils ([#4278](#4278)) ([7287662](7287662))
* Feature/adding remote online store ([#4226](#4226)) ([9454d7c](9454d7c))
* List all feature views ([#4256](#4256)) ([36a574d](36a574d))
* Make RegistryServer writable ([#4231](#4231)) ([79e1143](79e1143))
* Remote offline Store  ([#4262](#4262)) ([28a3d24](28a3d24))
* Set optional full-scan for deletion ([#4189](#4189)) ([b9cadd5](b9cadd5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants